Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI bug fixes - Part II #1619

Merged
merged 4 commits into from
Nov 24, 2023
Merged

CI bug fixes - Part II #1619

merged 4 commits into from
Nov 24, 2023

Conversation

gpmayorga
Copy link
Contributor

@gpmayorga gpmayorga commented Nov 23, 2023 •
edited
Loading

Fixes issue #1618

@gpmayorga gpmayorga requested a review from wischli as a code owner November 23, 2023 12:10
@gpmayorga gpmayorga added I12-ci Issue related to CI github_actions Pull requests that update GitHub Actions code Q0-trivial An issure which is similar to patching code. labels Nov 23, 2023
@gpmayorga gpmayorga marked this pull request as draft November 23, 2023 13:29
@gpmayorga gpmayorga marked this pull request as ready for review November 24, 2023 13:01
@gpmayorga
Copy link
Contributor Author

This is ready to go and should fix the issues with deploying the github pages using actions

@gpmayorga gpmayorga linked an issue Nov 24, 2023 that may be closed by this pull request
Fix Docs publishing (CI) #1618
Closed
@gpmayorga gpmayorga enabled auto-merge (squash) November 24, 2023 13:04
wischli
wischli approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

@gpmayorga gpmayorga merged commit 3e1aa4b into main Nov 24, 2023
8 checks passed
@gpmayorga gpmayorga mentioned this pull request Nov 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wischli wischli wischli approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code I12-ci Issue related to CI Q0-trivial An issure which is similar to patching code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Docs publishing (CI)
2 participants
@gpmayorga @wischli